Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enrich our OG tags with some extra info to help with Synerise integration #43

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

salesfelipe
Copy link

@salesfelipe salesfelipe commented Jan 8, 2025

What problem is this solving?

  • For the integration work properly we need some specific data to be presented in the OG tags. We were missing product:retailer_part_no which is the ProductID and the categories product:category.

Reference: https://hub.synerise.com/developers/web/og-tags/

How to test it?

Workspace

Screenshots or example usage:

Screenshot 2025-01-08 at 12 08 23

Describe alternatives you've considered, if any.

Related to / Depends on

How does this PR make you feel? 🔗

![](put .gif link here - can be found under "advanced" on giphy)

@salesfelipe salesfelipe requested a review from a team as a code owner January 8, 2025 15:13
@salesfelipe salesfelipe requested review from gabpaladino, vsseixaso and leo-prange-vtex and removed request for a team January 8, 2025 15:13
Copy link
Contributor

vtex-io-ci-cd bot commented Jan 8, 2025

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Jan 8, 2025

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

@salesfelipe salesfelipe self-assigned this Jan 8, 2025
@salesfelipe salesfelipe added the enhancement New feature or request label Jan 8, 2025
@@ -21,6 +21,7 @@ interface MetaTag {
}

function ProductOpenGraph() {
const { disableOffers } = useAppSettings()
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eslint made me refactor the usage of this hook

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant